[developer] Review 5238 iswgraph(L'a') returns 0, but iswctype(L'a', wctype("graph")) nonzero

Discussion:

Lauri Tirkkonen via illumos-developer

2014-10-22 14:32:44 UTC

Issue https://illumos.org/issues/5238
Webrev http://www.niksula.hut.fi/~ltirkkon/webrev/5238/

Simple fix (thanks Garrett), with some added tests.
--
Lauri Tirkkonen | +358 50 5341376 | lotheac @ IRCnet

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

Garrett D'Amore via illumos-developer

2014-10-22 14:51:35 UTC

Permalink

You need to add your new test to the runfiles for the libc test suite. Otherwise it looks good.

Sent from my iPhone

Post by Lauri Tirkkonen via illumos-developer
Issue https://illumos.org/issues/5238
Webrev http://www.niksula.hut.fi/~ltirkkon/webrev/5238/
Simple fix (thanks Garrett), with some added tests.
--
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21239177-3604570e
Modify Your Subscription: https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

Lauri Tirkkonen via illumos-developer

2014-10-22 15:24:06 UTC

Permalink

Post by Garrett D'Amore via illumos-developer
You need to add your new test to the runfiles for the libc test suite.
Otherwise it looks good.

Updated webrev.
--
Lauri Tirkkonen | +358 50 5341376 | lotheac @ IRCnet

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

David Höppner via illumos-developer

2014-10-22 15:02:49 UTC

Permalink

On 22 October 2014 16:32, Lauri Tirkkonen via illumos-developer

Post by Lauri Tirkkonen via illumos-developer
Issue https://illumos.org/issues/5238
Webrev http://www.niksula.hut.fi/~ltirkkon/webrev/5238/
Simple fix (thanks Garrett), with some added tests.

Did you run pbchk? wctype_test.c seems not to be clean.

-- David

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

Lauri Tirkkonen via illumos-developer

2014-10-22 15:19:09 UTC

Permalink

Post by David HÃ¶ppner via illumos-developer
Did you run pbchk? wctype_test.c seems not to be clean.

I did not - thanks, updated webrev.
--
Lauri Tirkkonen | +358 50 5341376 | lotheac @ IRCnet

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

Yuri Pankov via illumos-developer

2014-10-22 16:54:45 UTC

Permalink

On Wed, 22 Oct 2014 18:19:09 +0300, Lauri Tirkkonen Via

Post by Lauri Tirkkonen via illumos-developer

Post by David HÃ¶ppner via illumos-developer
Did you run pbchk? wctype_test.c seems not to be clean.

I did not - thanks, updated webrev.

Any reason to use license other than CDDL (some form of BSD, I guess)
for usr/src/test/libc-tests/tests/wctype/wctype_test.c?

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

Lauri Tirkkonen via illumos-developer

2014-10-22 17:01:55 UTC

Permalink

Any reason to use license other than CDDL (some form of BSD, I guess) for
usr/src/test/libc-tests/tests/wctype/wctype_test.c?

Just personal preference. It's ISC, should be compatible.
--
Lauri Tirkkonen | +358 50 5341376 | lotheac @ IRCnet

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

Garrett D'Amore via illumos-developer

2014-10-22 17:07:33 UTC

Permalink

ISC is fine. Admittedly I'm not thrilled about introducing yet another
license into the code base, but ISC is very liberal. (I'd have preferred
BSD if you are using liberal licenses, if only to match precedent.)

On Wed, Oct 22, 2014 at 10:01 AM, Lauri Tirkkonen via illumos-developer <

Post by Lauri Tirkkonen via illumos-developer

Any reason to use license other than CDDL (some form of BSD, I guess) for
usr/src/test/libc-tests/tests/wctype/wctype_test.c?

Just personal preference. It's ISC, should be compatible.
--
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
https://www.listbox.com/member/archive/rss/182179/21239177-3604570e
https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com

Richard Yao via illumos-developer

2014-10-22 17:10:30 UTC

Permalink

ISC is the 2-clause BSD license with language made unnecessary by the
Berne Convention removed. It is a BSD license in all but name.

If I recall correctly, the OpenBSD project requires that all new code be
under ISC.

Post by Garrett D'Amore via illumos-developer
ISC is fine. Admittedly I'm not thrilled about introducing yet another
license into the code base, but ISC is very liberal. (I'd have preferred
BSD if you are using liberal licenses, if only to match precedent.)
On Wed, Oct 22, 2014 at 10:01 AM, Lauri Tirkkonen via illumos-developer <

Post by Lauri Tirkkonen via illumos-developer

Any reason to use license other than CDDL (some form of BSD, I guess) for
usr/src/test/libc-tests/tests/wctype/wctype_test.c?

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/26621013-05fb2a43
Modify Your Subscription: https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com

Garrett D'Amore via illumos-developer

2014-10-22 17:27:54 UTC

Permalink

Yes, it seems so. Actually the language in the ISC license is quite clear.
:-)

We should probably make some kind of statement about licenses within the
illumos community. I'll send out a message later about this -- it doesn't
belong on this list.

Post by Richard Yao via illumos-developer
ISC is the 2-clause BSD license with language made unnecessary by the
Berne Convention removed. It is a BSD license in all but name.
If I recall correctly, the OpenBSD project requires that all new code be
under ISC.

Post by Lauri Tirkkonen via illumos-developer

Post by Yuri Pankov via illumos-developer
Any reason to use license other than CDDL (some form of BSD, I guess)

for

Post by Garrett D'Amore via illumos-developer

Post by Lauri Tirkkonen via illumos-developer

Post by Yuri Pankov via illumos-developer
usr/src/test/libc-tests/tests/wctype/wctype_test.c?

-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now

https://www.listbox.com/member/archive/rss/182179/26621013-05fb2a43
https://www.listbox.com/member/?&

Post by Garrett D'Amore via illumos-developer
Powered by Listbox: http://www.listbox.com

Yuri Pankov via illumos-developer

2014-10-22 17:13:05 UTC

Permalink

On Wed, 22 Oct 2014 10:07:33 -0700, Garrett D'amore Via

Post by Garrett D'Amore via illumos-developer
ISC is fine. Admittedly I'm not thrilled about introducing yet another
license into the code base, but ISC is very liberal. (I'd have
preferred BSD if you are using liberal licenses, if only to match
precedent.)

OK, didn't want to start license discussion, just noticed the following
in usr/src/README:

"...All new code must be licensed under CDDL..."

Post by Garrett D'Amore via illumos-developer
On Wed, Oct 22, 2014 at 10:01 AM, Lauri Tirkkonen via illumos-developer

Any reason to use license other than CDDL (some form of BSD, I guess) for
usr/src/test/libc-tests/tests/wctype/wctype_test.c?

Just personal preference. It's ISC, should be compatible.
--
Lauri Tirkkonen | +358 50 5341376 <tel:%2B358%2050%205341376> |
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
https://www.listbox.com/member/archive/rss/182179/21239177-3604570e
Modify Your Subscription: https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com
*illumos-developer* | Archives
<https://www.listbox.com/member/archive/182179/=now>
<https://www.listbox.com/member/archive/rss/182179/21175335-e81db5f4> |
Modify
<https://www.listbox.com/member/?&>
Your Subscription [Powered by Listbox] <http://www.listbox.com>