[developer] Review: 5016 improve mpt_sas auto request sense

[Hans Rosenfeld via illumos-developer]

Hi,

on behalf of Andy Giles I'd like to get review for this change:
http://ma.nexenta.com/~woodstock/illumos-mptsas-arq/

These changes improve the way auto request sense is implemented in
mpt_sas. The biggest improvement is that mpt_sas will now use one big
contiguous DMA buffer to allocate all auto request sense buffers from.
This is needed to enable 64bit DMA everywhere in mpt_sas, another change
which will come soon.

Another small improvement is that DEBUG builds of mpt_sas will record
the last sense data in a buffer. There is only one global buffer for all
mpt_sas instances, which might limit it's usefulness.


Hans
--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown


-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

[Dan McDonald via illumos-developer]

Post by Hans Rosenfeld via illumos-developer
Hi,
http://ma.nexenta.com/~woodstock/illumos-mptsas-arq/

I see nothing particularly objectionable here, save some cstyle nits that I'm sure git pbchk will catch. You may count me as a reviewer.

I would recommend, however, you get one other driver-wise reviewer (Keith W., Garrett, etc.) just to be sure, however.

Dan



-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com

[Hans Rosenfeld via illumos-developer]

Hi Dan,

Post by Dan McDonald via illumos-developer

Post by Hans Rosenfeld via illumos-developer
http://ma.nexenta.com/~woodstock/illumos-mptsas-arq/

I see nothing particularly objectionable here, save some cstyle nits
that I'm sure git pbchk will catch. You may count me as a reviewer.

Thanks for looking at this. My git pbchk didn't show anything, can you
point me to the nits you found?

Post by Dan McDonald via illumos-developer
I would recommend, however, you get one other driver-wise reviewer
(Keith W., Garrett, etc.) just to be sure, however.

Yes, that would be very good to have.


Hans
--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown


-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com