Dan McDonald via illumos-developer
2014-10-23 18:54:10 UTC
Point your browsers at:
http://kebe.com/~danmcd/webrevs/5224/
You'll see two directories:
5224-volatile/ -- Has a well-commented addition of "volatile" to local-variable 'z'.
5224-asm/ -- Has well-commented assembly subroutines for three libc internal functions.
The -asm one IMHO needs more testing, and I'd REALLY appreciate a close review. I ran the Richard PALO tests against it, and it didn't complain, just like it didn't complain against the volatile one. I chose deliberately NOT to make these inline, due to readability and that inlines appear to need to be instantiated multiple times (though perhaps not with newer devpros). Unlike SPARC and its limited register windows, x86 doesn't seem to havea penalty for function calls beyond memory and possibly cache misses.
Thanks,
Dan
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com
http://kebe.com/~danmcd/webrevs/5224/
You'll see two directories:
5224-volatile/ -- Has a well-commented addition of "volatile" to local-variable 'z'.
5224-asm/ -- Has well-commented assembly subroutines for three libc internal functions.
The -asm one IMHO needs more testing, and I'd REALLY appreciate a close review. I ran the Richard PALO tests against it, and it didn't complain, just like it didn't complain against the volatile one. I chose deliberately NOT to make these inline, due to readability and that inlines appear to need to be instantiated multiple times (though perhaps not with newer devpros). Unlike SPARC and its limited register windows, x86 doesn't seem to havea penalty for function calls beyond memory and possibly cache misses.
Thanks,
Dan
-------------------------------------------
illumos-developer
Archives: https://www.listbox.com/member/archive/182179/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182179/21175072-86d49504
Modify Your Subscription: https://www.listbox.com/member/?member_id=21175072&id_secret=21175072-abdf7b7e
Powered by Listbox: http://www.listbox.com